feat: add builder system transactions #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forge code coverage:
|
0age
reviewed
Sep 26, 2024
src/BuilderSystemTransactions.sol
Outdated
| /// @notice Sets the flashblock index | ||
| /// @dev Only a builder can set the flashblock index | ||
| /// @param _flashblockIndex The new flashblock index | ||
| function setFlashblockIndex(uint8 _flashblockIndex) external onlyBuilder { |
There was a problem hiding this comment.
should we include some basic verification here just to be safe? A simple version would be one where you can only increment by one or reset to zero (which should also require that the block number has increased by one), or a more sophisticated version would allow the owner to update a flashblocks-per-block variable and then that gets stepped through.
I would just worry as an app dev about relying on the builder to always operate with perfect accuracy, particularly if my application was counting on the "flashblocks always increase" invariant
There was a problem hiding this comment.
even if they do operate with perfect accuracy, it's a great way to communicate the intended behavior
this commit updates the flashblock logic to increment rather than set arbitrarily
marktoda
force-pushed
the
add-builder-system-transactions
branch
from
3c8bc8c to
9a0bbce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Please include a summary of the change and which feature was implemented or which issue was fixed. Also, include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:
Before deployment
After deployment
Considerations
forge fmtand prettier to ensure the code style is validAdditional context
Add any other context about the pull request here.